feat: add new frequencies command to show term frequencies
#48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This shows a count of each text/label combo, with a combined total for all annotators. It also flags when the same text has been labelled differently. Also: - Delete some unused code, notably the old unused term_freq code. - For the `mentions` command, don't show duplicate mentions - it's just noise. - For the `mentions` command, sort output by text (rather than using the order that the text appears in the document - which makes less sense when we're removing duplicates)
mikix
commented
Jun 26, 2024
There was a problem hiding this comment.
Just removing some unused code that I noticed.
dogversioning
approved these changes
Jun 27, 2024
|
|
||
| # Helper method to add all the info for a single annotator to our table | ||
| def add_annotator_to_table(name, label_to_text: dict) -> None: | ||
| nonlocal has_term_confusion |
There was a problem hiding this comment.
first time i've seen this keyword - i get the approach, i think it makes sense in this use case, but it makes me itchy.
maybe i just need time to come around on it, like our friend the walrus.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This shows a count of each text/label combo, with a combined total for all annotators. It also flags when the same text has been labelled differently.
Also:
mentionscommand, don't show duplicate mentions - it's just noise.mentionscommand, sort output by text (rather than using the order that the text appears in the document - which makes less sense when we're removing duplicates)Checklist
docs/) needs to be updated